Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host mapping feature merge #642

Merged
merged 8 commits into from
Jun 26, 2021
Merged

Host mapping feature merge #642

merged 8 commits into from
Jun 26, 2021

Conversation

sushanthakumar
Copy link
Collaborator

What this PR does / why we need it:
This PR contains changes related to host mapping feature merge
It contains

DB models and DB APIs
Hostmapping resource collection
Driver APIs definition
fake driver implementation to depict host->volume mapping
North bound API implementation

Reference issue : #568

Feature Design doc for reference:
RequirementsDesignSpec_HostMapping.docx

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Test report
DB Tables
Selection_462

DB Table Entries

Selection_454

Selection_455

Selection_456

Selection_457

Selection_458

Selection_459

Selection_460

Selection_461

image

NBP API snapshots:

image

Selection_465

Selection_466

Selection_467

Selection_469

Selection_470

Release note:

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #642 (8bf6625) into master (2393672) will decrease coverage by 1.01%.
The diff coverage is 58.80%.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   71.29%   70.27%   -1.02%     
==========================================
  Files         144      156      +12     
  Lines       13103    14273    +1170     
  Branches     1566     1700     +134     
==========================================
+ Hits         9342    10031     +689     
- Misses       3229     3692     +463     
- Partials      532      550      +18     
Impacted Files Coverage Δ
delfin/api/views/masking_views.py 42.85% <42.85%> (ø)
delfin/api/views/port_groups.py 42.85% <42.85%> (ø)
delfin/api/views/storage_host_groups.py 42.85% <42.85%> (ø)
delfin/api/views/storage_host_initiators.py 42.85% <42.85%> (ø)
delfin/api/views/storage_hosts.py 42.85% <42.85%> (ø)
delfin/api/views/volume_groups.py 42.85% <42.85%> (ø)
delfin/api/v1/storage_hosts.py 44.82% <44.82%> (ø)
delfin/db/sqlalchemy/api.py 69.07% <46.78%> (-11.04%) ⬇️
delfin/drivers/driver.py 63.76% <50.00%> (-2.90%) ⬇️
delfin/api/v1/masking_views.py 57.14% <57.14%> (ø)
... and 24 more

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit f57e70e into master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants